cph-cachet / carp-webservices-spring

REST-based implementation of the CARP Core Domain Model using Spring Boot in Kotlin
https://carp.cachet.dk/
MIT License
3 stars 2 forks source link

Open/close data stream tests #128

Closed davidscavnicky closed 1 month ago

davidscavnicky commented 1 month ago

The CoreDataStreamServiceTest class is well-structured and logically organized. The tests are grouped into nested classes based on the functionality being tested. Each test method follows a consistent structure, making the tests easy to read and maintain. There's one test that's lacking validity and that's getDataStream, with OutOfBounds issue with off set and on set of Sequence numbers, deeper dive ins and integration tests should shine more light into this matter. but for self contained testing this is not necessary.