search

cph-cachet / carp.core-kotlin

Infrastructure-agnostic framework for distributed data collection.
https://carp.cachet.dk/core/
MIT License
21 stars 3 forks source link

Add ApplicationData datatype #485

Closed yuanchen233 closed 1 month ago

yuanchen233 commented 1 month ago

As discussed in #484, introducing a new datatype to hold applicationDataand set default serializer to ApplicationDataSerializer. This way we don't need to specify the serializer used everytime we use applicationData.

Changes:

  1. New type ApplicationData holds a String field data.
  2. In ApplicationDataSerializer, a not null String value is expected for field data
  3. All applicationData are now type of ApplicationData?
  4. Update TypeScript wrapper
yuanchen233 commented 1 month ago

Sounds good.

I can rebase/move stuff for you if you want. Other than code style and commit order, I think these PRs are good to be merged.

Yes please, and thanks. I try to avoid doing interactive rebase here (at least for now), as there is a chance I mess up everything and creates more work for both of us. 🙂