[health]`callToHealthTypes` in HelathPlugin.kt calls `keyToHealthDataType` with wrong key always.

cph-cachet / flutter-plugins

A collection of Flutter plugins developed by CACHET

537 stars 642 forks source link

[health]`callToHealthTypes` in HelathPlugin.kt calls `keyToHealthDataType` with wrong key always. #201

Closed kouchi32 closed 3 years ago

kouchi32 commented 3 years ago

Device / Emulator and OS

Please complete the following information for each phone and/or emulator you're experiencing this bug on:

Pixel 3a
Android 10

Describe the bug

callToHealthTypes method calls keyToHealthDataType with wrong key that is ArrayList.toString(). ArrayList.toString() returns [WEIGHT] for example.

Expected behavior

DataPoints return always empty.

Additional information

There is PR. https://github.com/cph-cachet/flutter-plugins/pull/200

TylerStein commented 3 years ago

+1 applying this fixed an issue where permissions were not being granted on my end, resulting in Google auth errors when retrieving data. Thanks for the fix!

Tested on a Galaxy S8 and a Pixel 3a for the permissions: BODY_FAT_PERCENTAGE, STEPS, HEART_RATE, BODY_TEMPERATURE, BLOOD_GLUCOSE

thomasnilsson commented 3 years ago

Thank you, I will review and merge this.

thomasnilsson commented 3 years ago

Merged in version 2.0.7 :)