cph-cachet / flutter-plugins

A collection of Flutter plugins developed by CACHET
546 stars 656 forks source link

[Health 10.1.1] Code formatting on Android is questionable, can I fix it? #936

Closed ciriousjoker closed 1 month ago

ciriousjoker commented 6 months ago

Description

There is absolutely no way that 152 spaces of indentation is considered good practice by anyone. Additionally, the indentation arbitrarily changes to an even higher value past a certain point, why is that?

We're planning to use this at our company and I intend to make some contributions towards stability on Android, but I'm not going to be able to replicate whatever formatting is going on here since Android Studio pushes me towards the standard 4 space indentation even when I disable autoformatting in this repo.

If the current formatting is intentional and not just negligence, I'm very curious to hear the reasons behind it, otherwise:

TLDR: Are you guys open to a PR that just formats the whole HealthPlugin.kt file using the default Kotlin formatter?

Additional information

CleanShot 2024-03-30 at 16 09 22@2x

CleanShot 2024-03-30 at 16 11 21@2x

SlimShadyIAm commented 1 month ago

This should be better on master now :)