search

cphyc / matplotlib-label-lines

Label line using matplotlib.
MIT License
301 stars 28 forks source link

Log x ax #5

Closed HPLegion closed 6 years ago

HPLegion commented 6 years ago

Hi cphyc

I have added some demo code showing off the logscale axis to the readme I also noticed that, I had implemented the change in a way that it only works when xvals==None. Since xvals==None can be seen as a special case of type(xvals) == tuple, where xvals = ax.get_xlim(), I have slightly restructured the code to cover both cases. Let me know if you agree with this solution. All the demo code runs fine after these changes, as far as I can tell.

Cheers

codecov-io commented 6 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #5   +/-   ##
======================================
  Coverage    99.2%   99.2%           
======================================
  Files           3       3           
  Lines         125     125           
======================================
  Hits          124     124           
  Misses          1       1
Impacted Files Coverage Δ
labellines/core.py 98.3% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48c3835...e0b221c. Read the comment docs.

cphyc commented 6 years ago

Awesome thanks!

cphyc commented 6 years ago

I just bumped the version number and uploaded the latest release on pypi (https://pypi.org/project/matplotlib-label-lines/#description).

You should be able to get the latest change using pip install -U matplotlib-label-lines.

HPLegion commented 6 years ago

Cool :) Thanks for the cooperation!

firstpullrequest #mumisproud :-P