search

cpiber / NebulaEnhance

A browser extension for bringing quality-of-life features to https://nebula.app
MIT License
39 stars 2 forks source link

"Percent to hide" property not working #45

Closed wolleydev closed 1 year ago

wolleydev commented 1 year ago

As soon as I have any amount of watch progress on a video it will get hidden. I have tried using different percentages (normally would use 100) to no avail.

It also seems like even when clearing watch progress videos will not always re-appear. From what I can tell it works if I use "clear watch progress" but not if I open the video and put the progress bar to zero manually - but I am not entirely sure about that.

I am not sure if this appeared recently or if it just took some time for me to notice

I am using latest stable Firefox version on W10.

Thanks for your work.

cpiber commented 1 year ago

It also seems like even when clearing watch progress videos will not always re-appear. From what I can tell it works if I use "clear watch progress" but not if I open the video and put the progress bar to zero manually - but I am not entirely sure about that.

That is on Nebula's side unfortunately, since I can only use their progress indicator.

As for the other things, I'll have to check, I thought it was working fine until recently...

cpiber commented 1 year ago

I just tried to reproduce it and it seems to work fine: image

Watching a bit further, it was then hidden (screenshot with hiding disabled): image

This has led me to another bug though, due to a change in the API. But the behavior is the same. Firefox 112.0.2 (64-bit).

If you really sure that the video shouldn't be hidden, can you please post information from the console here: Please open the browser console (DevTools, e.g. by hitting F12 and switching to the console tab), enable debug log (upper right), reload the page (where you expected to see the video) and try to copy all the messages

cpiber commented 1 year ago

Please re-open if you still have problems

wolleydev commented 1 year ago

Please re-open if you still have problems

Hey, Sorry I was on vacation these last couple days. I still have this problem. I watched a couple seconds off the most recent video in my feed and it disappeared. Rest of the hidden videos are hidden as they should as they have reached 100%.

Here are the logs:

Youtube: true Theme: null visitedColor: #6fbce6 
Hiding 0 creators   videos? true with perc watched: 100 [content_script.js:1:63495](moz-extension://b3546a4f-f282-47a9-b73f-ed06fe799c10/scripts/content_script.js)
Detected theme null [content_script.js:1:63684](moz-extension://b3546a4f-f282-47a9-b73f-ed06fe799c10/scripts/content_script.js)
playbackChange: 0.1 autoplay? false autoplay in queue? true 
volume scroll? false change: 0.1 log? false show? true 
use first subtitle? true [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Navigating to page myshows from <empty string> [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Loading finished for page myshows [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 16 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 19 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 20 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 17 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 0 video(s) by hidden creators [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
Hiding 12 watched video(s) [instrument.ts:124](https://nebula.tv/static/node_modules/@sentry/src/instrument.ts)
cpiber commented 1 year ago

Hm, you have it set to 100, so it shouldn't hide any videos actually.

I don't know how I missed that, but apparently the problem occurs on the "My Library" page. The video should still appear on the "Videos" page. I'll look into it.

cpiber commented 1 year ago

Apparently I missed another change in the API, dump mistake. I'll release another version soon.