Closed meshula closed 4 months ago
Thanks for the patch @meshula ! I'll update usdtweak this week-end (or feel free to make a PR if you want). It looks like the recorder can process multiple frames now ? I haven't checked yet but may be it is possible to directly pass the vector of frames to process, I'll try. Thanks again !
@jonny-apple says he was able to compile without this patch, maybe I'm the one who's out of date. Maybe hold off spending time on it until I can confirm?
sure ! In any case I'll setup a compilation of usd head this week-end, this can be useful to keep track of the changes.
I just compiled usdtweak, and the only change for the dev branch I had to make is the following:
diff --git a/src/viewport/Viewport.cpp b/src/viewport/Viewport.cpp
index c4eb9a4..515c36d 100644
--- a/src/viewport/Viewport.cpp
+++ b/src/viewport/Viewport.cpp
@@ -601,7 +601,7 @@ void Viewport::Render() {
CameraUtilFraming framing(displayWindow, dataWindow);
_renderer->SetRenderBufferSize(renderSize);
_renderer->SetFraming(framing);
- _renderer->SetOverrideWindowPolicy(std::make_pair(true, CameraUtilConformWindowPolicy::CameraUtilMatchVertically));
+ _renderer->SetOverrideWindowPolicy(std::make_optional(CameraUtilConformWindowPolicy::CameraUtilMatchVertically));
// If using a usd camera, use SetCameraPath renderer.SetCameraPath(sceneCam.GetPath())
// else set camera state
Thanks @expenses ! I'll update UT this week-end.
Was this issue resolved with https://github.com/cpichard/usdtweak/commit/e01216de08fdc64721c7fa14c56fced9276186d6 ?
If so, I suppose this issue can be closed?
Yes, I think its fine to close.
Hi, usdtweak compiles and runs with top of tree USD dev branch, with this tweak. Maybe it'd be possible to do something like this guarded on a version check or something?