Remove comment and include null check for `selectedImage`

aamir-s18 commented 2 years ago

Hey Christopher,

this is a great project! We modified the Vikus Viewer and used it as a part of our project.

Some minor things:

It would be great to remove the console.log statements or introduce a debug config flag. (Maybe you can have a dev branch where you keep them).
Also, I am not sure if it is necessary to have the time information from the tsne
In js/canvas.js we had some errors with selectedImage. In line 374 and 663.

I removed the comments and fixed the selectedImage in this repo. If you agree, with the removal of the comments, I can a make Pull request :).

cpietsch commented 2 years ago

Wow this is great!

Once there was no console.log, but I must have left it in at some point. We could overwrite window.console into a noop function here https://github.com/cpietsch/vikus-viewer/blob/master/js/utils.js#L20 or remove all the console.logs

cpietsch commented 2 years ago

I made a pull request from your repo https://github.com/cpietsch/vikus-viewer/pull/28 Thanks again!

cpietsch / vikus-viewer