cpignata / eimpact-icmp

4 stars 0 forks source link

Initial commit -01 #7

Closed jmparikh closed 6 months ago

jmparikh commented 6 months ago
  1. Added a new file attic/todos-01.md (This file has the summarized feedback which, upon evaluation, can be good potential additions to the document)
  2. Added "administrative domain" to relevant places (Jari's Feedback)
  3. New section "Transport options for sustainability information" (Jari's Feedback)
  4. Changed "impact object" to "information object" (Jari's Feedback)
  5. Updated C-Type Definition Section: Added Units to the already defined metrics (Jari's Feedback) Made some changes to the list to make it mode intelligible
  6. Some XML doc formatting
  7. Added Jari to acknowledgements
mwelzl commented 6 months ago

Ohhhhhhhhh I see now, I made all my suggestions for the TEXT file, not the XML file!!! I will do it all again, for the XML file - so sorry! Please wait... I'll issue another review. SIGH

mwelzl commented 6 months ago

Here it's 10pm now... I promise to do my review again, applied to xml, tomorrow!