Update usaco-739.mdx - Githubissues

cpinitiative / usaco-guide

A free collection of curated, high-quality resources to take you from Bronze to Platinum and beyond.

https://usaco.guide

Other

1.56k stars 464 forks source link

Update usaco-739.mdx #4543

Open Gautam-Singhvie opened 2 weeks ago

Gautam-Singhvie commented 2 weeks ago

I would like for you to consider my Python solution to this problem to be uploaded as the Internal Solution. It is a clearer and more efficient solution to the problem. It also passes on all tests unlike the existing python solution ; ). Hope this helps other python users!

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

[ ✓] I have tested my code.
[ ✓] I have added my solution according to the steps here.
[x] I have followed the code conventions mentioned here.
- I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
- If changes are requested, I will re-request a review after addressing them.
[ ] I have linked this PR to any issues that it closes.

Gautam-Singhvie commented 2 weeks ago

Hi! It is my first time sending a pull request! Do let me know if I should change anything.

Gautam-Singhvie commented 2 weeks ago

Is there a strict convention on using "with" and the print using "file" argument? The template I used is mentioned on USACO guide itself.

SansPapyrus683 commented 2 weeks ago

no yeah uh those conventions are pretty outdated lol

Gautam-Singhvie commented 2 weeks ago

So should i resolve the 2 change conversations without any changes?

SansPapyrus683 commented 2 weeks ago

uuuhhh no? you should make the changes i requested

Gautam-Singhvie commented 2 weeks ago

I have noticed that my code looks simpler. Should I still change it? I found this simpler template on USACO guide beginner section itself.

SansPapyrus683 commented 2 weeks ago

uh look would you mind if i just made all the requested changes myself

Gautam-Singhvie commented 2 weeks ago

uh look would you mind if i just made all the requested changes myself

That would be fine by me! Go right ahead.

stale[bot] commented 3 days ago

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!