search

cpisciotta / xcbeautify

A little beautifier tool for xcodebuild
MIT License
983 stars 72 forks source link

Fixed handling -q for certain scenarios involving test cases #139

Closed grigorye closed 1 year ago

grigorye commented 1 year ago

This should fix the following scenarios involving -q and test cases:

  1. A succeeding test case preceding the erroneous one from the same test suite is used as the "header", when reporting the error, instead of the test suite "header".
  2. In case of parallel testing, "Testing failed on 'XXX'" triggering output of last succeeding test case as the "header"
  3. If combined with --no-ci, first failing test case is reported with the "header" from the last non-test related content.

I'm not sure if there's some other scenario related to the problem. So far, this is what I encountered in real life.

Case 1

Before:

Screenshot 2023-07-18 at 09 50 57

After:

Screenshot 2023-07-18 at 09 52 01

Case 2

Before:

Screenshot 2023-07-18 at 09 52 40

After:

Screenshot 2023-07-18 at 09 53 07

Case 3 (invocation with --is-ci and -q)

Before:

Screenshot 2023-07-18 at 10 24 56

After:

Screenshot 2023-07-18 at 10 27 37
grigorye commented 1 year ago

Sorry, there's a problem with -no-ci -q in the current version – looking into it.

cpisciotta commented 1 year ago

@grigorye Thanks for the detailed description and comments. LGTM!

cpisciotta commented 1 year ago

@grigorye Looks like there's some tests that you'll need to fix before merging.

grigorye commented 1 year ago

@grigorye Looks like there's some tests that you'll need to fix before merging.

Thanks, I updated the tests. @cpisciotta