search

cpisciotta / xcbeautify

A little beautifier tool for xcodebuild
MIT License
983 stars 72 forks source link

Enable duplicated symbols location output #153

Closed blastmann closed 8 months ago

blastmann commented 1 year ago

Try to fix #150.

  1. Support printing LinkerDuplicateSymbolsLocation and LinkerUndefinedSymbolLocation in Terminal and GithubActionsLog.
  2. Fix ldWarning matching. The original regex of warning will match ldWarning also, then message output is hidden sometimes.
  3. Level up undefinedSymbolLocation to error.
blastmann commented 1 year ago

Hey @blastmann! Thanks for improving xcbeautify! Looks like we need to clean up a few things before this is ready to merge.

As part of this PR, can you please add some unit tests against your changes?

Let me know if you have any questions!

Unit test is added. Check please.

github-actions[bot] commented 11 months ago

Hola 👋,

We want to let you know that your pull request has been marked as stale. It seems that there hasn't been any activity or updates on it for a while.

If you're still interested in having this pull request merged or reviewed, please provide any necessary updates or address any feedback that may have been given. We would be happy to continue the review process and consider merging it into the main branch.

However, if this pull request is no longer a priority or if you've decided to take a different approach, please let us know so we can close it accordingly.

Thank you for your understanding and contribution.

github-actions[bot] commented 11 months ago

Hola 👋,

We want to let you know that we have decided to close your pull request #456 due to prolonged inactivity. Despite the initial interest and efforts put into the pull request, we haven't seen any updates or responses for a considerable period of time.

We understand that circumstances change and priorities shift, which may have led to this inactivity. If you still wish to contribute or have further discussions on this feature or bug fix, please don't hesitate to reopen the pull request and engage with the community.

We appreciate your understanding and the time you invested in submitting the pull request. Your contributions are valuable, and we hope to collaborate with you on future endeavors.

Thank you.

pepicrft commented 10 months ago

What's the state of this? We'll have to rebase the most recent changes in main.

blastmann commented 10 months ago

What's the state of this? We'll have to rebase the most recent changes in main.

Actually, I've done what I can do in this PR. If anyone has any comments about this change list, please let me know.