search

cpisciotta / xcbeautify

A little beautifier tool for xcodebuild
MIT License
947 stars 67 forks source link

Drop Bazel Support #182

Closed cpisciotta closed 7 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5df94fd) 85.83% compared to head (ccfeb2c) 85.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #182 +/- ## ======================================= Coverage 85.83% 85.83% ======================================= Files 13 13 Lines 1842 1842 ======================================= Hits 1581 1581 Misses 261 261 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sanju-naik commented 7 months ago

@cpisciotta Any reason we are dropping Bazel support? We use this library to format our Bazel build output logs.

And also from the code changes it looks like We are dropping support for building this library with Bazel, but formatting bazel build logs using this library is still supported? Is my understanding correct?

cpisciotta commented 7 months ago

@sanju-naik This PR drops support for building the xcbeautify project itself with Bazel. I don't use the Bazel build system, so I dropped support for it since I'm not maintaining it. As I understand it, this change breaks support for projects using xcbeautify (namely XcbeautifyLib) as an out-of-the-box Bazel dependency. Importantly, I do not intend to drop formatting support for output generated by a Bazel project.