Closed cpisciotta closed 6 months ago
Closing, since this'll drop SPM support for 5.7 and 5.8.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
083aedf
) 85.83% compared to head (a6725cd
) 85.88%.
Files | Patch % | Lines |
---|---|---|
...ces/XcbeautifyLib/Renderers/TerminalRenderer.swift | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bumping to Swift 5.9 introduces some particularly helpful new features, namely the
package
access modifier (SE-386). Bumping to Swift 5.9 is a breaking change for consumers ofXcbeautifyLib
, such as Tuist, since their packages will also require Swift 5.9 too. It is not a breaking change if a consumer simply uses thexcbeautify
CLI. Thepackage
access modifier will be particularly helpful to introduce new logic intoXcbeautifyLib
that the executable,xcbeautify
, needs, without unnecessarily making the additions public to third-party consumers.