search

cpisciotta / xcbeautify

A little beautifier tool for xcodebuild
MIT License
939 stars 65 forks source link

Migrate Formatting to CaptureGroup Definitions #232

Closed cpisciotta closed 6 months ago

cpisciotta commented 7 months ago

In an effort to simplify the codebase, introduce a formatted method as a CaptureGroup protocol requirement. This'll house the formatted output, eliminating the need for separate OutputRendering definitions and switch logic.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (092bb2d) 85.76% compared to head (31d9715) 86.80%.

Files Patch % Lines
Sources/XcbeautifyLib/CaptureGroups.swift 88.56% 39 Missing :warning:
Sources/XcbeautifyLib/TestSummary.swift 0.00% 12 Missing :warning:
Sources/XcbeautifyLib/Parser.swift 66.66% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== + Coverage 85.76% 86.80% +1.04% ========================================== Files 14 11 -3 Lines 1545 1258 -287 ========================================== - Hits 1325 1092 -233 + Misses 220 166 -54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cpisciotta commented 6 months ago

Closing this, since it tightly couples formatting to the concrete types.