search

cpisciotta / xcbeautify

A little beautifier tool for xcodebuild
MIT License
915 stars 62 forks source link

Added support for skipped tests #271

Closed alistra closed 3 months ago

alistra commented 4 months ago

Fixing #205.

I added support for skipped tests.

Added support in junit reporting - unfortunately the output doesn't show the XCTSkip message, so the message is not passed to the xml.

For terminal reporting I used ⊘ as the character for the status - copied it over from some open source python library for unit testing.

TODO & Question: I have no idea how to handle it in the Github actions reporter - please tell me what to do there - I will implement it. So far the output is same as passing test I believe - but with the ::notice :: marker.

alistra commented 3 months ago

@cpisciotta any chance you could take a look at this or approve the CI? :)

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.05%. Comparing base (12b9926) to head (d329670).

Files Patch % Lines
Sources/XcbeautifyLib/JunitReporter.swift 83.33% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #271 +/- ## ========================================== + Coverage 85.72% 86.05% +0.32% ========================================== Files 14 14 Lines 1492 1563 +71 ========================================== + Hits 1279 1345 +66 - Misses 213 218 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cpisciotta commented 3 months ago

Hey @alistra! Sorry for the delayed response. Thank you for contributing to xcbeautify! I really appreciate it, and I'll be sure to review your PR today. In the meantime, I've approved the CI to run.

alistra commented 3 months ago

Did not notice the make lint make format commands :) - now should be OK