search

cpitclaudel / alectryon

A collection of tools for writing technical documents that mix Coq code and prose.
MIT License
227 stars 36 forks source link

Syntax error in `alectryon/alectryon/transforms.py` using Python 3.7.5 #59

Closed jhaag closed 3 years ago

jhaag commented 3 years ago

In our CI we're using Python 3.7.5. I recently attempted to bump our version of alectryon but immediately ran into a syntax error within this line. In particular, the use of the single-starred expression to create a variable length tuple is apparently not supported as it is currently written (i.e. return obj.conclusion, *obj.hypotheses).

I believe that if you change this line to return (obj.conclusion, *obj.hypotheses) then the code will continue working for the versions you test but it will also work with Python 3.7.5

cpitclaudel commented 3 years ago

Ah, yes, thanks! Will push a fix, I have a local patch :)

cpitclaudel commented 3 years ago

OK, closed by f3284f7 I think.

jhaag commented 3 years ago

Yep, I just confirmed that this works locally.

cpitclaudel commented 3 years ago

Thanks!

cpitclaudel commented 3 years ago

(Sorry btw, I should have rebased the commit to credit the issue report)

jhaag commented 3 years ago

Haha, I appreciate your thoughtfulness but I'm much more invested in functionality rather than attribution ;~)