search

cpitclaudel / biblio.el

Browse and import bibliographic references from CrossRef, DBLP, HAL, arXiv, Dissemin, and doi.org from Emacs
GNU General Public License v3.0
185 stars 15 forks source link

Added backend for Google Scholar #25

Closed nchodosh closed 5 years ago

nchodosh commented 6 years ago

I added a few functions to make a backend for Google Scholar out of this similar package

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-98.1%) to 1.717% when pulling 1c532b5b6ce73124aa579cf2c0540c429da00bb1 on nchodosh:master into a5a68fcf677f286f205f32dc7486f6c9f66aa6af on cpitclaudel:master.

nchodosh commented 6 years ago

The tests fail because it depends on the other project which isn't installed. Would it be better to just take everything needed from that repo to remove the dependency?

cpitclaudel commented 6 years ago

This looks great! Sorry for the delay.

Taking the dependency out would be better if we include this in core, but another good approach might be to publish this as a separate plugin on melpa; biblio was built to be extensible, so it would be completely fine to publish a biblio-gscholar package to MELPA and make that depend on gscholar-bibtex.

What do you think?

nchodosh commented 6 years ago

Sorry for the delay on my end! Yes that sounds great, it might take a a bit since I've never published anything on MELPA before. Once that's done could you add a note to the README of this project to let people know that it exists?

cpitclaudel commented 6 years ago

Once that's done could you add a note to the README of this project to let people know that it exists?

Yes, absolutely

nchodosh commented 6 years ago

Would you mind testing the extension on your end? I was working on it and it seems that Google has upped their anti-scraping game and it's refusing to load the results without javascript. Some python scrapers I downloaded seem to be having the same problem.

nchodosh commented 6 years ago

Would you mind testing the extension on your end? I was working on it and it seems that Google has upped their anti-scraping game and it's refusing to load the results without javascript. Some python scrapers I downloaded seem to be having the same problem.

cpitclaudel commented 5 years ago

Sorry for the delay. As I said, I think it would be ideal to have this as a separate MELPA package, since it depends on non-trivial Google Scholar parsing. I'll be happy to link to it from the README once it's ready ^^

seanfarley commented 1 year ago

Sorry for the delay. As I said, I think it would be ideal to have this as a separate MELPA package, since it depends on non-trivial Google Scholar parsing. I'll be happy to link to it from the README once it's ready ^^

I was in need of this functionality so I went ahead and made it into a package here: https://github.com/seanfarley/biblio-gscholar.el

@nchodosh, if you like, please feel free to take ownership of the repo I created. I'm not sure about what copyright to assign it, by the way, which means I'm not sure if it can be submitted to melpa as-is. Anyways, hope this helps others.