cpitclaudel / biblio.el

Browse and import bibliographic references from CrossRef, DBLP, HAL, arXiv, Dissemin, and doi.org from Emacs
GNU General Public License v3.0
185 stars 15 forks source link

check for advice in addition to checking for completing-read-function having its default value & set more relax url timeout #58

Closed nicehiro closed 1 year ago

nicehiro commented 2 years ago

For vertico users who want to use vertico(default completing function) to show biblio candicates, they can check for advice of completing-read-default to avoid using ido-completing-read.

Please check issue https://github.com/cpitclaudel/biblio.el/issues/55

Also, set a more relax url timeout to make sure every url request ok.

Please also check https://github.com/cpitclaudel/biblio.el/issues/39

cpitclaudel commented 2 years ago

Thanks a lot. Would the following check work instead? It only uses public API functions.

(catch 'advised (advice-mapc (lambda () (throw 'advised t)) 'completing-read-default))

Otherwise we can go with your test

nicehiro commented 2 years ago
(catch 'advised (advice-mapc (lambda () (throw 'advised t)) 'completing-read-default))

This worked and I resubmit it.

cpitclaudel commented 1 year ago

Thanks for your patience.