search

cpitclaudel / biblio.el

Browse and import bibliographic references from CrossRef, DBLP, HAL, arXiv, Dissemin, and doi.org from Emacs
GNU General Public License v3.0
180 stars 14 forks source link

Add support for Google Books querying #60

Closed jrasband closed 9 months ago

jrasband commented 9 months ago

Hi, this is a PR that adds support for querying Google Books. I felt like this was needed because the existing backends don't provide much support for books, especially non-scientific books.

The only external dependency is curl, but there's probably a way to remove that dependency if wanted. I used biblio-arxiv.el and biblio-ieee.el as templates so that biblio-googlebooks.el is as similar as possible to the existing codebase.

This is my first time submitting a pull request and I'm an Elisp amateur, so I'm happy to take any feedback.

cpitclaudel commented 9 months ago

This looks really nice! We could merge it here, but to allow to evolve it in the future, would you be open to making it its own package? This way we gain in modularity (and submitting a package to MELPA is super easy).

jrasband commented 9 months ago

I'm open to making biblio-googlebooks its own package.

I'm happy to try to submit to MELPA (daunting as that may be). However, would you mind adding a short paragraph under "Backends" on the README that explains your preference for new backends to be submitted to MELPA as separate packages rather than PRs to biblio.el? This will prevent people like me from submitting PRs in the future and should save you time reviewing them. Additionally, I think it might be helpful if the README also contains a list of available external backends (both MELPA and non-MELPA) to improve discoverability. If you don't have time to make those edits to the README, I'm willing to submit a PR at some point.