search

cpjk / canary

:hatching_chick: Elixir authorization and resource-loading library for Plug applications.
MIT License
474 stars 51 forks source link

regard non_id_actions in do_load_resource like in do_authorize_resour… #73

Closed philippneugebauer closed 4 years ago

philippneugebauer commented 7 years ago

…ce to prevent crashes

fixes #71

philippneugebauer commented 7 years ago

@cpjk What do you think about this?

cpjk commented 4 years ago

👋 Hey! I'm sorry for the lack of movement on this. I shouldn't have left this for so long without a reply.

I am not currently writing Elixir at all, and therefore, I think it would be irresponsible of me to review PRs on this project. I just kept putting off reviewing the issues/PRs on this repo until I started writing Elixir again, but never got around to it.

That is my mistake, and I'm really sorry about that 🙏. You put in the time to make this PR, and you deserve a response at the very least.

I've marked the project as "not being actively maintained" in the readme. Please feel free to fork it with a different name and put it up on hex with current fixes.

philippneugebauer commented 4 years ago

No worries, I switched to bodyguard anyway