search

cpjk / canary

:hatching_chick: Elixir authorization and resource-loading library for Plug applications.
MIT License
474 stars 51 forks source link

Handle not found with required #83

Open quexpl opened 4 years ago

quexpl commented 4 years ago

Fixes #82

TwelveNights commented 4 years ago

One question I have about your implementation is that, if the resource is a nested resource, is there a case in which we don't care if the parent exists? It seems to me that this "nested resource" would not be really nested if the parent ends up being nil.

I guess the issue is that we don't know if a resource is a parent or not unless we use another keyword, though.

Anyways, great PR :)

quexpl commented 4 years ago

I've explained it a bit in related issue #82