search

cpldcpu / light_ws2812

Light weight library to control WS2811/WS2812 based LEDS and LED Strings for 8-Bit AVR microcontrollers.
GNU General Public License v3.0
946 stars 207 forks source link

Request to add a tag for v2.4 #103

Closed u1f992 closed 4 months ago

u1f992 commented 5 months ago

Thank you for developing this useful library. I have been relying on it, particularly for projects involving the ATtiny10. While I was little disappointed to see support for the ATtiny10 dropped in v2.5, I understand the challenges on maintaining support for such constrained hardware as well as the necessity to enhance performance for other newer devices.

I noticed that v2.4 does not have a corresponding git tag. This version will be crucial for those of us using some devices, and currently, we have to refer to the commit directly as per the README. Adding a tag for v2.4 would greatly simplify access to this important version and help ensure stable builds for our projects.

Could you please consider adding a git tag for v2.4? This would be immensely helpful for those of us needing to maintain compatibility.

cpldcpu commented 5 months ago

Good point, the update also broke compatibility for the reduced AVR core.

And indeed, I forgot to tag v2.4. But at this point it appears difficult to do so, becuase a lot of smaller additions have been submitted, so it is difficult to pinpoint.

I think it may be easier, just to add compatibility back in for that ATtiny10. Would you be willing to test?

u1f992 commented 5 months ago

Of course. It may take a little time to follow up, but I will try.

cpldcpu commented 5 months ago

There you go: https://github.com/cpldcpu/light_ws2812/tree/v2.6testing

Please let me know if it works on-device, I will release it then.

u1f992 commented 4 months ago

@cpldcpu Sorry it took so long. It works properly with ATtiny10. https://github.com/U-1F992/attiny10-neopixel

cpldcpu commented 4 months ago

No problem, there is no rush. Thank you very much! Will merge.