search

cpliakas / git-wrapper

A PHP wrapper around the Git command line utility.
MIT License
506 stars 68 forks source link

The GitException must contains the previous exception when available #141

Closed soullivaneuh closed 6 years ago

soullivaneuh commented 6 years ago

On those lines: https://github.com/cpliakas/git-wrapper/blob/5a2b0a89b84347decebe084c2cc266c9e1c7583e/src/GitProcess.php#L91-L94

The caught exception must be passed as previous parameter. Currently, we can't know which exception was catch except with message and it breaks the code flow.

TomasVotruba commented 6 years ago

You are right. Could you send PR?

soullivaneuh commented 6 years ago

@TomasVotruba Can we release it on both 1.x and 2.x?

soullivaneuh commented 6 years ago

It seems not, since we only have master branch. :confused:

TomasVotruba commented 6 years ago

I maintain only 2.0+ as stated here

If you need older branches and are willing to maintaint it, state your voice there. I'm sure that won't be a problem.

soullivaneuh commented 6 years ago

Well, it will be a new reason to move my a** and make an upgrade. :laughing: