Closed soullivaneuh closed 6 years ago
Probably related to https://github.com/cpliakas/git-wrapper/pull/144
It indeed solves the issue about the deprecation message, but your code still override the run
method.
When the vendor method will be really final, you will have this error:
Fatal error: Cannot override final method Symfony\Component\Process\Process::run() in /code/vendor/cpliakas/git-wrapper/src/GitProcess.php on line 10
In GitProcess.php line 10:
[Symfony\Component\Debug\Exception\FatalErrorException]
Compile Error: Cannot override final method Symfony\Component\Process\Process::run()
It may be better to remove inheritance?
The other solution would be to override the start
method instead, which is called by run
.
Could you send PR to make it work?
While running git commands: