Closed rugabarbo closed 4 years ago
For some strange reason, Nette Utils uses flag PREG_SPLIT_DELIM_CAPTURE
by default when splitting lines:
https://github.com/nette/utils/blob/f1dc08536b040d5b569ee63354343145cbe6c591/src/Utils/Strings.php#L435
Because of this, Strings::split() also returns delimiters in the result set. Therefore, the Rector’s recommendation is incorrect.
Because of this, Strings::split() also returns delimiters in the result set. Therefore, the Rector’s recommendation is incorrect.
Could you create issue in Rector?
Could you use it anyway? It should be possible
Could you create issue in Rector?
https://github.com/rectorphp/rector/issues/2348
Could you use it anyway? It should be possible
I used regex without subpatterns. Now all tests are green.
@TomasVotruba is everything okay now? :) Could you please merge it? I really need this fix to remove the temporary hack from yii-dev-tool package:
Looks good
In some configurations, there is no guarantee that the system uses
PHP_EOL
delimiter for console output. See issue https://github.com/yiisoft/yii-dev-tool/issues/42 for details.