Closed hostep closed 4 years ago
I don't think that's what we actually want. I think we should fix the caller so it only calls this method with the correct types.
A formal change log is provided at https://github.com/cpliakas/git-wrapper/blob/master/upgrade/rector/git-wrapper-30.yaml.
I don't think that's what we actually want. I think we should fix the caller so it only calls this method with the correct types.
Actually, there does seem to a bug here, with this. I think the return type of this method is also wrong...
Does https://github.com/cpliakas/git-wrapper/pull/201 fix your issue?
Hi!
I just attempted upgrading from version 2.2.0 to 3.0.1 (an up-to-date changelog would handy btw, but no pressure 😉) and I ran into this error:
This happened when calling the
log
method on aGitWorkingCopy
instance:It interprets
xxx
in the argument-n xxx
as an integer and callingstrlen
on an integer throws the above error. Probably due tostrict_types
being enabled.Suggested would be to change:
to
Does this make sense?
Thanks!