getCommandLine should return string|string[]

cpliakas / git-wrapper

A PHP wrapper around the Git command line utility.

MIT License

505 stars 68 forks source link

getCommandLine should return string|string[] #201

Closed GrahamCampbell closed 4 years ago

GrahamCampbell commented 4 years ago

The underlying symfony process class actually needs this to be string[], even though they only document the type as array in the Process constructor, but later they do an array_map to a function that is strongly typed as string...

Closes https://github.com/cpliakas/git-wrapper/issues/200.

GrahamCampbell commented 4 years ago

Ping @TomasVotruba.

TomasVotruba commented 4 years ago

GitHub didn't submit feedback on mobile. Should be there now

TomasVotruba commented 4 years ago

Thanks!