search

cpliakas / git-wrapper

A PHP wrapper around the Git command line utility.
MIT License
505 stars 68 forks source link

nette/utils should be required #202

Closed samdark closed 4 years ago

samdark commented 4 years ago

Currently the package is in require-dev but is used in primary source code: https://github.com/cpliakas/git-wrapper/blob/master/src/GitBranches.php#L9

GrahamCampbell commented 4 years ago

Maybe better to just change the code to not need the dependency?

TomasVotruba commented 4 years ago

This takes less time to fix than create an issue, describe it and link the exact line where it cannot be fixed :)

samdark commented 4 years ago

@GrahamCampbell yes, that's even better.

samdark commented 4 years ago

@TomasVotruba it's better to have a plan confirmed before doing a pull request. See how @GrahamCampbell suggested way better solution...

samdark commented 4 years ago

I'm preparing a pull request...

samdark commented 4 years ago

Done.

TomasVotruba commented 4 years ago

@samdark PR is a plan :). It could be merged/rejected already.

samdark commented 4 years ago

@TomasVotruba would you please tag a release?

TomasVotruba commented 4 years ago

There you go: https://github.com/cpliakas/git-wrapper/releases/tag/v3.0.2