search

cpliakas / git-wrapper

A PHP wrapper around the Git command line utility.
MIT License
506 stars 68 forks source link

Do not depend on nette #203

Closed samdark closed 4 years ago

samdark commented 4 years ago

Fixes #202

TomasVotruba commented 4 years ago

Why this change? The issue was named "nette/utils should be required". What did you meant by that?

preg_ is super hard to read - you need to learn extra constants - and error prone.

samdark commented 4 years ago

@TomasVotruba that was suggested by @GrahamCampbell and I liked the idea of less dependencies. If you don't like it, feel free to add nette to require instead.

TomasVotruba commented 4 years ago

It's important to look at gains + losses, not just gains. Less dependencies !== more sustainable code for the the future.

It's just duplicated code with PHP-vendor lock now, I don't see much value in it.

If you don't like it, feel free to add nette to require instead.

:+1:

samdark commented 4 years ago

https://github.com/cpliakas/git-wrapper/pull/204