search

cpliakas / git-wrapper

A PHP wrapper around the Git command line utility.
MIT License
505 stars 68 forks source link

Allow the Symfony 3.4 event dispatcher #205

Closed pfrenssen closed 4 years ago

pfrenssen commented 4 years ago

I would like to use this with Drupal 8 which still requires the Symfony 3.4 event dispatcher. There is hardly any difference between the 3.4 and 4.x versions of the event dispatcher, so there should be little harm in allowing this version.

GrahamCampbell commented 4 years ago

I don't think this actually works, and the test didn't fail because they didn't install 3.4.

Instead, you should use the 1.7.x series of this package. That is the latest version for Symfony 3.

pfrenssen commented 4 years ago

Argh, then it will be affected by the failure that was reported in #145, which is not easy to fix since it is failing because of a method signature incompatibility between 3.4 and 4.x.

Oh well, I will update the signature in my fork and use this for the next couple months. When Drupal 9 is out we will be able to switch back to the official version.

GrahamCampbell commented 4 years ago

That incompatibility is actually of the process component and not the event component.

GrahamCampbell commented 4 years ago

It looks like the coding standard stuff in the dev-dependencies is what is preventing us from testing on symfony event-dispatcher 3.4.x due to them depending on symfony http-kernel.

pfrenssen commented 4 years ago

Aha thanks for the pointer, I will have another look in the morning.

TomasVotruba commented 4 years ago

The new Symfony version is on purpose to make maintained scope smaller. It prevents this packages from dying like it happened before.

Closing as wontfix. Upgrade your dependencies

pfrenssen commented 4 years ago

The new Symfony version is on purpose to make maintained scope smaller. It prevents this packages from dying like it happened before.

I'm not suggesting to downgrade, just to expand the supported versions. I'm fine with the new versions also being supported.

Upgrade your dependencies

This is not always possible. Some projects (such as Drupal) are still on Symfony 3.4. It will be minimum 5 months before Drupal projects will be able to upgrade to Symfony 4. In any case Symfony 3.4 is still supported until November 2021.

TomasVotruba commented 4 years ago

This is not always possible. Some projects (such as Drupal) are still on Symfony 3.4. It will be minimum 5 months before Drupal projects will be able to upgrade to Symfony 4.

It's always possible. When that projects adopts early adoption, it's scope will narrow to, thus make it faster to upgrade and develop. In big projects it will bring even more value to whole community, as feature adoption will become status quo, not pain.

pfrenssen commented 4 years ago

I would argue that it's also "always possible" to support existing versions for at least their announced life times. It doesn't usually take much effort and you can widen your user base to include projects that value stability over early adoption. This is especially important for a library such as git-wrapper.

Drupal projects fall squarely in the long term stability camp, as it is mostly chosen for large government and Fortune 500 style corporate projects.

GrahamCampbell commented 4 years ago

https://travis-ci.org/cpliakas/git-wrapper/jobs/654943174 shows that the code really doesn't work on Symfony's event-dispatcher 3.4.

GrahamCampbell commented 4 years ago

@pfrenssen You can still use the 1.x series of this library. It is newer than Symfony 3.x in terms of the last time a feature was commited there.

GrahamCampbell commented 4 years ago

Consider 1.x as LTS of this library I guess. I'd assume the maintainer would accept security fixes to 1.x, should any arise.

pfrenssen commented 4 years ago

Ok I will do so and stick to 1.x for our Drupal work, thanks for the assistance and reassurance that this branch is still supported!