Open cpliakas opened 3 years ago
Hi @cpliakas ,
I'm all good :) thanks for asking. You're reading my mind. I've been doing something similar with other external repositories I maintain.
E.g. last year I've moved object-calisthenics under Symplify: https://github.com/object-calisthenics/phpcs-calisthenics-rules/pull/108
Doing the same with this package means 50 % less maintenance, as Symplify is a monorepo. So there is almost no extra work.
It usually requires to deprecate package on Packagist:
And recommend replacement ↓
If you're up to it, I can create mirror of this package and create symplify/git-wrapper
@TomasVotruba Sounds good to me! Is there any action you need from me or anything I can help with?
Phew :) It took 8 hours more then expected to fit Symplify PHPStan standards, but now it's ready https://github.com/symplify/symplify/pull/2909
Here to be published: https://github.com/symplify/git-wrapper
I've used standard Symplify MIT license, so the responsiblity is on me. Let me know if it's ok like this :)
anything I can help with?
If it's all good, could you abbandong the git-wrapper on packagist and re-commend this package? https://packagist.org/packages/symplify/git-wrapper
That should help with the switch.
Just an update: I have the access on packagist, so I've tried to deprecate the package:
The functionality and API should be the same now, just namespace changed:
-use GitWrapper\...;
+use Symplify\GitWrapper\...;
That's the minimum next step we can take now :)
I recommend to wait a couple of weeks now, to see how the transition goes. If there are some bugs, we can fix them before going to wider community.
Then we can inform folks here that there is a migration to do, with prepared @rectorphp set to run. That way people don't to invest any energy to migrate and the job is done.
Thank you both for your work on this excellent package!
Getting the composer message:
Package cpliakas/git-wrapper is abandoned, you should avoid using it. Use symplify/git-wrapper instead.
Does that mean it is now safe to migrate to symplify/git-wrapper
?
Yes, that's where this package will be developed in the future
Great, thanks @TomasVotruba!
It appears that symplify/git-wrapper
requires PHP 7.3 and above, whereas my package has to work with PHP 7.2 and above.
https://github.com/symplify/git-wrapper/blob/014537930e613525df39f6d17429b9443c91a38a/composer.json#L7
Guess I'm stuck with the abandoned version until I can bump my PHP version requirements.
Using PHP 7.2 is dangerous as there are no security updates anymore. Upgrade to PHP 7.3 at least.
Tell me about it! I maintain a plugin (package) for @craftcms which currently has a minimum requirement of PHP 7.2.5, so my hands are tied.
I feel you :/
Nowadays the upgrade can be done with tools - look at @rectorphp (I wrote), https://getrector.org/blog/2020/11/30/smooth-upgrade-to-php-8-in-diffs
Love the package and the blog post @TomasVotruba! Unfortunately I have to wait for @craftcms to update their PHP requirements, which should be in the next major version.
I see :) It seems they allow PHP 8.1.dev too - https://github.com/craftcms/cms/blob/3f88316387ca91ceaf9b63dc9983e17b77b510e2/composer.json#L21 Or is it another package?
They do, but I build and distribute plugins (https://github.com/putyourlightson/craft-blitz for example) for Craft which can in theory be installed by people running PHP 7.2, so gotta support it.
I see. With that Rector can help too. You can develop in PHP 8 and downgrade on release way down to PHP 7.1 - https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#downgradephp80
Ooh, well that is really interesting, thanks for mentioning it!!
Hi @TomasVotruba!
I hope all is well with you, and it has been great to watch the progress of this tool from the sidelines. Nothing burning on my side, and happy to keep the repo as-is. I was wondering it it would make sense to either transfer this repository to your account (or some other approach) that would give you more control over the repo and supporting toolchain. I just wanted to raise the question.