search

cpllab / lm-zoo

Easy black-box access to state-of-the-art language models
https://cpllab.github.io/lm-zoo/
MIT License
14 stars 6 forks source link

JRNN evaluation does not correctly use model bos/eos tokens #18

Closed hans closed 4 years ago

hans commented 4 years ago

https://github.com/cpllab/lm-zoo/blob/master/models/JRNN/eval_test_google.py

See data_utils.CharVocabulary.encode -- each sentence needs a bos and eos token.

hans commented 4 years ago

Fixed in API v2 upgrade at f0ca263a3c6f68be8886eadf51aef8774a4cd909