search

cplusplus / draft

C++ standards drafts
http://www.open-std.org/jtc1/sc22/wg21/
5.69k stars 749 forks source link

Flat map assorted editorial improvements #5726

Open tkoeppe opened 2 years ago

tkoeppe commented 2 years ago

See https://github.com/cplusplus/draft/pull/5626 for remaining, unaddressed suggestions.

@jwakely, @CaseyCarter ^^^

tkoeppe commented 2 years ago

We should consider styling the "exposition-only" members of flat*_map as \exposid.

JohelEGP commented 2 years ago

We should consider styling the "exposition-only" members of flat*_map as \exposid.

Please, see https://github.com/cplusplus/draft/pull/5696#discussion_r939344294.

JohelEGP commented 2 years ago

Might https://github.com/cplusplus/draft/pull/5626#discussion_r922744940 and https://github.com/cplusplus/draft/pull/5626#discussion_r922820452 need a LWG issue? Those deduction guides are useless. So changing that might not classify as editorial.

tkoeppe commented 2 years ago

Might #5626 (comment) and #5626 (comment) need a LWG issue? Those deduction guides are useless. So changing that might not classify as editorial.

I certainly want to hear from the LWG chair about this before moving further.

JohelEGP commented 2 years ago

Here's some refactoring for simpler wording. -- https://github.com/cplusplus/draft/pull/5626#pullrequestreview-1041120671

https://github.com/cplusplus/draft/pull/5626/files#r922759807: What is range? e.first might be ill-formed.

https://github.com/cplusplus/draft/pull/5626#discussion_r922758379: Inconsistent handling of unmet complexity guarantees.

~https://github.com/cplusplus/draft/pull/5626#discussion_r922820982 should be harmonized with https://github.com/cplusplus/draft/pull/5626#discussion_r944648854.~

https://github.com/cplusplus/draft/pull/5626#discussion_r922718166: C is not an iterator.

tkoeppe commented 2 years ago

@jwakely Could you please take a look at those "useless deduction guides" above?

JohelEGP commented 2 years ago

I opened https://github.com/cplusplus/draft/issues/5800 just for that.