Open tkoeppe opened 2 years ago
We should consider styling the "exposition-only" members of flat*_map as \exposid
.
We should consider styling the "exposition-only" members of flat*_map as
\exposid
.
Please, see https://github.com/cplusplus/draft/pull/5696#discussion_r939344294.
Might https://github.com/cplusplus/draft/pull/5626#discussion_r922744940 and https://github.com/cplusplus/draft/pull/5626#discussion_r922820452 need a LWG issue? Those deduction guides are useless. So changing that might not classify as editorial.
Might #5626 (comment) and #5626 (comment) need a LWG issue? Those deduction guides are useless. So changing that might not classify as editorial.
I certainly want to hear from the LWG chair about this before moving further.
Here's some refactoring for simpler wording. -- https://github.com/cplusplus/draft/pull/5626#pullrequestreview-1041120671
https://github.com/cplusplus/draft/pull/5626/files#r922759807: What is range
? e.first
might be ill-formed.
https://github.com/cplusplus/draft/pull/5626#discussion_r922758379: Inconsistent handling of unmet complexity guarantees.
~https://github.com/cplusplus/draft/pull/5626#discussion_r922820982 should be harmonized with https://github.com/cplusplus/draft/pull/5626#discussion_r944648854.~
https://github.com/cplusplus/draft/pull/5626#discussion_r922718166: C
is not an iterator.
@jwakely Could you please take a look at those "useless deduction guides" above?
I opened https://github.com/cplusplus/draft/issues/5800 just for that.
See https://github.com/cplusplus/draft/pull/5626 for remaining, unaddressed suggestions.
@jwakely, @CaseyCarter ^^^