cplusplus / draft

C++ standards drafts
http://www.open-std.org/jtc1/sc22/wg21/
5.59k stars 739 forks source link

N4944 pre-CD: Remaining inconsistent inline constexpr variable templates #6204

Open Dani-Hub opened 1 year ago

Dani-Hub commented 1 year ago

After the recent adjustment to strike "inline" from constexpr variable templates, the following cases are still present (looking at the N4944 pre-CD working draft):

1) [ranges.syn]:

namespace views {
  template<size_t N>
    inline constexpr unspecified adjacent = unspecified; // freestanding
  [...]
}
[...]
namespace views {
  template<size_t N>
    inline constexpr unspecified adjacent = unspecified; // freestanding
  [...]
}
[...]
namespace views {
  template<size_t N>
    inline constexpr unspecified adjacent_transform = unspecified; // freestanding
  [...]
}

2) [range.refinements]:

template<class R>
  inline constexpr bool is-initializer-list = see below ; // exposition only
tkoeppe commented 1 year ago

Thanks, I agree we should fix that. @jwakely, do you agree?

jwakely commented 1 year ago

I agree.

tkoeppe commented 1 year ago

Thank you both, sounds good! Does either of you fancy making a PR? :-) If not, I'll get to it in a bit.

On Wed, 29 Mar 2023 at 11:54, Jonathan Wakely @.***> wrote:

I agree.

— Reply to this email directly, view it on GitHub https://github.com/cplusplus/draft/issues/6204#issuecomment-1488376291, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQVF6N6YYN4CAGCCNWI3DDW6QIIFANCNFSM6AAAAAAWE46VOY . You are receiving this because you commented.Message ID: @.***>

Dani-Hub commented 1 year ago

I can work on that.

tkoeppe commented 1 year ago

Thanks a lot!

On Wed, 29 Mar 2023 at 13:47, Daniel Krügler @.***> wrote:

I can work on that.

— Reply to this email directly, view it on GitHub https://github.com/cplusplus/draft/issues/6204#issuecomment-1488539819, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQVF6PKWLN62YRKNBA5MN3W6QVN7ANCNFSM6AAAAAAWE46VOY . You are receiving this because you commented.Message ID: @.***>

frederick-vs-ja commented 11 months ago

This should have been fixed.