search

cplusplus / nbballot

Handling of NB comments in response to ballots
14 stars 4 forks source link

JP004 17.11.2.2 p5 Bad ordering returned #380

Closed jensmaurer closed 3 years ago

jensmaurer commented 4 years ago

If v is unordered value, the following expression returns v, but it should return partial_ordering::unordered. Returns: v < 0 ? partial_ordering::greater : v > 0 ? partial_ordering::less : v.

Change expression as follows: Returns v.is_ordered ? (v < 0 ? partial_ordering::greater : v > 0 ? partial_ordering::less : v) : partial_ordering::unordered

JP6

jensmaurer commented 4 years ago

I think the consensus on the -lib reflector was NAD, i.e. "Reject".

zygoloid commented 4 years ago

Rejected. No consensus for change. If v is unordered, then returning v and returning partial_ordering::unordered are identical, so the suggested change is equivalent to the existing text.

tkoeppe commented 3 years ago

Final disposition: Rejected; see above for details.