search

cplusplus / nbballot

Handling of NB comments in response to ballots
14 stars 4 forks source link

JP010 31.8.1 p25 memcpy needs a pointer as its first argument #386

Closed jensmaurer closed 3 years ago

jensmaurer commented 3 years ago

In the following example, the first parameter of memcpy should be pointer value: memcpy(expected, this, sizeof(*this));

Change the example as follows memcpy(&expected, this, sizeof(*this));

JP12

jensmaurer commented 3 years ago

This was fixed by commit e674373e2515868ca17b24157f30515fad62b8e6 in the main branch and needs to be cherry-picked to the c++20 branch.

tkoeppe commented 3 years ago

Final disposition: Accepted.