search

cplusplus / nbballot

Handling of NB comments in response to ballots
14 stars 4 forks source link

**-040 6.8.2 [basic.fundamental] All notes labeled as "NOTE1" #582

Closed jensmaurer closed 9 months ago

jensmaurer commented 9 months ago

In 6.8.2 all notes are labelled erroneously as NOTE1. Please correct.

tkoeppe commented 9 months ago

This is on me.

jensmaurer commented 9 months ago

This isn't visible on my locally-generated PDF. Did something go wrong in the DIS submission?

tkoeppe commented 9 months ago

Yes, I changed the formatting and numbering to the ISO format "NOTE", "NOTE 1", "NOTE 2", etc. The numbering requires some trickery because "notes shall be numbered only if there is more than one" :-S This must have gone wrong somehow.

jensmaurer commented 9 months ago

Ok, can we merge this to the main branch, too?

tkoeppe commented 9 months ago

I'd rather not. The ISO format is strictly inferior since it loses the end marker.

I found the problem. It's rather silly. It's a 1 10 2 3 4 kind of situation.

jensmaurer commented 9 months ago

@tkoeppe, I think this is now fixed, right?

tkoeppe commented 9 months ago

Yes, thanks!