cplusplus / papers

ISO/IEC JTC1 SC22 WG21 paper scheduling and management
612 stars 19 forks source link

P2499 string_view range constructor should be explicit #1158

Closed wg21bot closed 1 year ago

wg21bot commented 2 years ago

P2499R0 string_view range constructor should be explicit (James Touton)

Bekenn commented 2 years ago

I neglected to specify a ship vehicle in the paper. It should be C++23. This is a fix for a feature that is new in C++23. If the fix is postponed, it will be a breaking change.

jensmaurer commented 2 years ago

@brycelelbach , please note that the author wants this as a C++23 fix (which we might very well apply as late as post-CD, since it's a fix for a new feature that could/should have also come in via an NB comment).

inbal2l commented 2 years ago

@Bekenn, @jensmaurer, thank you for getting our attention. We figured it's a breaking change and originally scheduled this paper for a Jan LEWG ML review. @brycelelbach suggested we can see it post Feb as well (minor fix). In any case, I've updated the revision in the LEWG ML queue: https://github.com/cplusplus/LEWG/wiki/2022-Mailing-List-Reviews

vitaut commented 2 years ago

While the change itself is minor I wouldn't categorize P2499 as a minor fix because the new implicit conversions introduced in C++23 are extremely problematic. There will be one more paper about this in the January mailing but if P2499 was adopted sooner it would be even better.

cor3ntin commented 2 years ago

2022-02-08 Library Evolution Telecon

P2499R0: string_view range constructor should be explicit

P2516R0: string_view is implicitly convertible from what?

2022-02-08 Library Evolution Telecon P2499 Minutes

2022-02-08 Library Evolution Telecon P2516 Minutes

__POLL: We want to make the range constructor of string_view explicit (P2499R0)__

Strongly Favor Favor Neutral Against Strongly Against
3 17 1 0 0

Attendance: 35

# of Authors: 1

Author Position: SF

Outcome: Consensus

A similar poll on P2516 (#1174) was taken, P2499 got stronger support, therefore was forwarded.

Next Steps

Take an electronic poll to send P2499R0 (string_view Range Constructor Should Be Explicit) to Library Working Group for C++23, classified as B2 - Improvement.

brycelelbach commented 2 years ago

2022-05 Library Evolution Electronic Poll Outcomes

__POLL: Send [P2499R0] string_view Range Constructor Should Be Explicit to Library Working Group for C++23, classified as an improvement of an existing feature ([P0592R4] bucket 2 item).__

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
13 7 1 2 0

Consensus in favor.

JeffGarland commented 1 year ago

LWG reviewed and approved 2022-07-08 Notes: https://wiki.edg.com/bin/view/Wg21telecons2022/P2499-20220708

poll: Put P2499r0 into C++23

F A N
16 0 1