Closed LB-- closed 9 years ago
Are you going to do that before you commit the pull or after?
We're not going to merge this until I've completed all of the goals, I just wanted a way to allow for discussion as I worked.
While you're digging around in here, would it be much to implement check/checkmate functionality? The code for movement and capturing looks pretty complicated and I wasn't able to figure out what was going on.
I thought I listed that on my goals, I've edited it in now.
What confuses you with movement and capturing?
I don't remember if this was ever finished. I guess it has to be now.
Well it builds and runs. I looked it over and didn't see anything obviously missing. It's a lot cleaner approach than the previous.
Back when I initially refactored this project, I ended up having to make Piece an inner class of Board because I didn't know you didn't need a complete type for references. As a result I designed everything to work under the assumption that Piece was internal to Board.
Unfortunately we now need to split them apart. In this PR my goals are to:
friend
s with each other (current)Please look over the changes with each commit and comment on what you think needs to be changed.
@ResidentBiscuit I assigned you to this PR since we're letting Thumper relax for a while.