search

cplussharp / graph-studio-next

GraphStudioNext is a tool for developers to build and test DirectShow Graphs
354 stars 94 forks source link

Appveyor build binaries have different version number from Appveyor version number #299

Closed mikecopperwhite closed 3 years ago

mikecopperwhite commented 7 years ago

For example Appveyor page https://ci.appveyor.com/project/cplussharp/graph-studio-next/build/0.7.1.6 gives version number as 0.7.1.6 but version number on graphstudionext.exe is 0.7.1.0

Not familiar with Appveyor and whether it's possible for Appveyor to change the resource version number. Perhaps it's just a FAQ if not.

cplussharp commented 7 years ago

I think the version number is an Environment Variable during the Appveyor build. I didn't had time to figure out how to include this during build.

mikecopperwhite commented 7 years ago

Looks like we have a choice between the full version with dot separators e.g 0.7.1.9 or just the build number e.g. 9

Not sure how to convert dot separated Appveyor version 0.7.1.9 into the comma separated version that will work with the version info resource.

The alternative is to hardcode the first three digits of the version number in VersionNo.h and use the Appveyor build number for the last digit if it's available.

cplussharp commented 7 years ago

Seems we have worked on the same issue ;) I have removed the appveyor text and included some conditional comments for the PreprocessorDefinitions in the project files. Because if the envvar APPVEYOR_BUILD_VERSION is not set the definition is empty and I couldn't build localy.

mikecopperwhite commented 7 years ago

Seems fixed now. Not much point in auto generating build number for local builds.