search

cpmodel / FTT_StandAlone

Future Technology Transformation models
GNU General Public License v3.0
10 stars 1 forks source link

Survival function FTT:Tr #101

Closed Femkemilene closed 6 months ago

Femkemilene commented 6 months ago

The vehicle_number - age matrix should work now, but it's not yet vectorised (faster), nor properly coupled to other parts of the model, so a draft pull request. Question: I'm not seeing the age matrix RLTA in the front end manager (it's all zeros). Any idea how to fix this, Cormac?

I'm not planning to write the efficiency correction in the code, but this should now be easier. Plan to work on this again on Friday.

cormacmlynch commented 6 months ago

I can see RLTA in the front end. It appears fine until 2023 where it starts to decline unexpectedly. I gather it just works with historical vehicles for now and not vehicles added in the simulation period?

image

Femkemilene commented 6 months ago

The survival function doesn't "do" anything yet, but it should be working correctly. Note that data issues of historical capacity means RLTA is more spikey than ideal. REVS, which is what we'll be using to compute second-hand batteries to power, is quite smooth. The speed of the run is still high (12 s), so I'm happy to enable this in main.

cormacmlynch commented 6 months ago

Is it expected that new cars in RLTA (i.e., cars aged 0) do not match TEWI? I'm assuming that the difference is caused by the current simple way of calculating TEWI by dividing by the lifetime and eventually we can use the survival function to find TEWI instead?

Femkemilene commented 6 months ago

Yes, that's expected. Before we replace the calculation for TEWI, we probably want to fix the issue with historical data first (see issue #105)