search

cpmodel / FTT_StandAlone

Future Technology Transformation models
GNU General Public License v3.0
9 stars 1 forks source link

Ftt ih update #144

Open rhayward1 opened 4 weeks ago

rhayward1 commented 4 weeks ago

The version of FTT-IH in main is behind both in terms of data and bug fixes in the code. This version is consistent with the FTT Iter E3ME update, but most importantly contains corrected data, which ensures that the results of the model will make sense.

This version should not cause any conflicts with main.

Femkemilene commented 3 weeks ago

I fixed some indentation bugs, but can't test it properly as the frontend doesn't seem to work today on my work laptop. We've reworked the code so that, in general, the csv files are automatically updated from the masterfiles when running the code for the first time. Is there a reason that all the csv files are saved separately here still?

rhayward1 commented 3 weeks ago

I fixed some indentation bugs, but can't test it properly as the frontend doesn't seem to work today on my work laptop. We've reworked the code so that, in general, the csv files are automatically updated from the masterfiles when running the code for the first time. Is there a reason that all the csv files are saved separately here still?

The masterfile for IH is out of date and doesn't have the newest data in it. The csvs are up to date. I created another issue asking for a code which could update the masterfile based on the csvs - I know this exists but I don't have a copy. Happy to sort this out today if you have that code!

pv-camecon commented 2 weeks ago

Not sure what is going on with this pull request, but I'm unable to investigate the results through the front-end.

Femkemilene commented 1 week ago

I fixed the indentation error again (this time it appeared in two models). When I try to run the model, I'm getting the following error: image. @pv-camecon : is that similar to your error? That is, or can you run the model but not see the output?

Femkemilene commented 1 week ago

Furthermore, in ftt_p_lcoe, the new gamma (1+gamma) is implemented. But this code doesn't yet have these new gamma values, right?

rhayward1 commented 1 week ago

This error happens because the IH models are missing from the FTT_Variables spreadsheet. I just added them all but I didn't commit as it would have conflicted with Main. I can commit the version I have and we can merge.

The new gamma value implementation shouldn't be in the update branch, only in the gamma automation branch, I can remove it. Sorry about that!

rhayward1 commented 1 week ago

Everything is now running if I run one IH model at a time, but I get an error if I try to run more than one. This seems to be caused by something in master files_to_csv.py.