search

cpmodel / FTT_StandAlone

Future Technology Transformation models
GNU General Public License v3.0
9 stars 1 forks source link

Resolve celib dependencies in Upload_FTT #44

Closed Femkemilene closed 4 months ago

Femkemilene commented 11 months ago

Upload_FTT.py now uses celib to find the dimensions of variables. This means that we should either rewrite this in to use Variable_Listing.xlsx, or we make celib available more widely. A compromise may be to include celib in the (private) support repo.

pv-camecon commented 11 months ago

Perhaps it's useful to rethink how we store the FTT inputs in general. Preprocessing everything into a pickle file save a lot of loading time. However, pickle objects are a security risk (I think). It also requires any user to have some understanding of Python in order to meddle with the inputs or to create new scenarios.

If it's preferable to stick to csv files, then we can make use of the classification_titles.xlsx file as we only use the titles databank anyway.

Femkemilene commented 10 months ago

When you say store files in pickle files, do you mean the individual country files? It's okay if people can't read those in easily, given that the same data is more easily accessible in the Masterfiles. Keeping the Masterfiles ensures we can keep the model close to E3ME-FTT, as we use the same input.