search

cporrasa / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter
0 stars 0 forks source link

Extremely large \bord values are not rendered correctly #166

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

Open any .ass script that uses a bord value of 100 and render the subtitle 
script beyond the video's native resolution.
For example "{\bord100}TEST TEST TEST" causes the error as seen in the attached 
image and subtitle script.

---
What is the expected output? What do you see instead?

Correct scaling is the expected output, inconsistent glitching is what appears 
instead.

---
What version of the product are you using? On what operating system?

3.1.0.546 of XySubFilter and 0.86.11 of madVR. Windows 7.

Original issue reported on code.google.com by m459cl...@gmail.com on 16 Aug 2013 at 9:20

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Bug can also reproduced using \bord150 with xy-VSFilter 3.0.0.211 and Aegisub 
CSRI without scaling. This regression seems to have occurred when we replaced 
the extremely slow border rendering code from legacy VSFilter with an adaption 
of "A Fast Bresenham Type Algorithm For Drawing Ellipses by John Kennedy".

We'll look into it.

Original comment by cyber.sp...@gmail.com on 16 Aug 2013 at 9:29

GoogleCodeExporter commented 8 years ago 
This has been fixed for our next release. The corruption was caused by the 
potential for the new border algorithm to overflow the 32bit integers with 
extremely large border sizes.

Original comment by cyber.sp...@gmail.com on 20 Aug 2013 at 9:41