search

cporrasa / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter
0 stars 0 forks source link

Unable to load subtitle files with uppercase extension (e.g. ASS) #174

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Put Example.mkv (containing 1 video & 1 audio stream) and Example.ASS in the 
same folder.
2. Open Example.mkv in MPC-HC
3. XySubFilter is loaded automatically (configured setting: Load when 
needed/External+Embedded) but no subtitles are displayed. The entry in the 
Filters menu says "XySubFilter (Connected to madVR, None)".

What is the expected output? What do you see instead?
The subtitle file should be loaded correctly. The ISR of MPC-HC will load it 
just fine, independent of the extension being lowercase or uppercase. 
If I rename the subtitle file from Example.ASS to Example.ass it is loaded 
correctly and fully works as expected.

What version of the product are you using? On what operating system?
Windows 7 x64, MPC-HC x86 v1.7.0.7858, madVR v0.86.11, xy-SubFilter v3.1.0.546

Please provide any additional information below.
Even when I use the Open command in the config dialog of the running filter and 
specify the subtitle file explicitly, it is not loaded if it has an uppercase 
extension and no error message is displayed.
I was able to reproduce this error with xy-vsfilter as well. I also tried 
changing the LOAD_EXT_LIST value (replaced ass with ASS) in
HKEY_CURRENT_USER\Software\Gabest\VSFilter\General
and
HKEY_CURRENT_USER\Software\Gabest\XySubFilter\General
That only had the effect that neither Example.ASS nor Example.ass could be 
loaded, with the same behavior as described above.
I think this should be fixed because on Windows the file systems used are 
typically case-insensitive and extensions are hidden by default, so a less 
technically inclined user would have no chance to recognize why certain 
subtitle files are just silently ignored. Depending on the source, the names of 
downloaded subtitle files sometimes are uppercase all the way, including the 
extension.

Original issue reported on code.google.com by inventor...@gmail.com on 3 Nov 2013 at 5:06

GoogleCodeExporter commented 8 years ago

Original comment by cyber.sp...@gmail.com on 8 Feb 2014 at 3:55

GoogleCodeExporter commented 8 years ago 
The XySubFilter Test Build attached at the below link contains a fix for this:

http://code.google.com/p/xy-vsfilter/issues/detail?id=181#c10

Original comment by cyber.sp...@gmail.com on 24 Apr 2014 at 8:06