cpp-best-practices / gui_starter_template

A template CMake project to get you started with C++ and tooling
The Unlicense
2.5k stars 447 forks source link

Fix coverage reporting #191

Closed lefticus closed 2 years ago

lefticus commented 2 years ago

Note: these issues were discovered while using a recent project made from the template. I think most of these issues are long standing. Previously ENABLE_COVERAGE was enabled by default, so it happened to work, but Release builds were not doing what we thought they were doing.

codecov-commenter commented 2 years ago

Codecov Report

Merging #191 (1bc4c99) into main (1e56cae) will decrease coverage by 20.00%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              main     #191       +/-   ##
============================================
- Coverage   100.00%   80.00%   -20.00%     
============================================
  Files            2        3        +1     
  Lines           20       35       +15     
  Branches         0       18       +18     
============================================
+ Hits            20       28        +8     
- Misses           0        6        +6     
- Partials         0        1        +1     
Flag Coverage Δ
Linux 38.46% <ø> (∅)
Windows 80.00% <ø> (-20.00%) :arrow_down:
macOS 38.46% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/tests.cpp 100.00% <0.00%> (ø)
test/constexpr_tests.cpp 100.00% <0.00%> (ø)
src/main.cpp 46.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e56cae...1bc4c99. Read the comment docs.