search

cpp-best-practices / travels

This is an awesome submission to the C++ Best Practices Game Jam
59 stars 9 forks source link

clang-tidy warnings for lesson 0 & 1 #5

Open 0xBachmann opened 2 years ago

0xBachmann commented 2 years ago

consider adding '-readability-named-parameter' to the clang-tidy file, otherwise trying to build the project will fail for lesson 0 and 1 as there are a lot of unnamed parameters in those lesson. thanks for your work it is super fun to play around with your game

lefticus commented 2 years ago

Can you verify what clang-tidy you are using? many different versions run on several targets on the CI, and I'm not getting any of those failures.

0xBachmann commented 2 years ago

I use version 10 (x86_64-pc-linux-gnu) but just realized, that the problem occurred not with any of the lessons but with the game itself, only there are lambdas with unnamed parameters.

arun5309 commented 2 years ago

I am facing the same issue when clang-tidy (LLVM version: 12.0.1) is checking game.cpp, game_components.cpp and all game hacking lesson files. Adding '-readability-named-parameter' to the clang-tidy file didn't fix the issue for me. So, I added '/unused/' in place of the unnamed parameters and it fixed it for me.

lefticus commented 2 years ago

OK, I'll look into this this week. I just got back from a bunch of training and conference travel.