search

cpp-linter / cpp-linter-action

A Github Action for linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of file-annotations, thread-comments, workflow step-summary, and Pull Request reviews.
https://cpp-linter.github.io/cpp-linter-action/
MIT License
87 stars 20 forks source link

Bump the pip group with 2 updates #224

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps the pip group with 2 updates: clang-tools and cpp-linter.

Updates clang-tools from 0.12.0 to 0.12.1

Release notes

Sourced from clang-tools's releases.

v0.12.1

🐛 Bug fixes

📝 Documentation updates

Full Changelog: https://github.com/cpp-linter/clang-tools-pip/compare/v0.12.0...v0.12.1

Commits


Updates cpp-linter from 1.7.4 to 1.8.0

Release notes

Sourced from cpp-linter's releases.

v1.8.0

🚀 New features and improvements

🐛 Bug fixes

✍ Other changes

📦 Dependency updates

Full Changelog: https://github.com/cpp-linter/cpp-linter/compare/v1.7.4...v1.8.0

Commits


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
github-actions[bot] commented 3 months ago

Cpp-Linter Report :warning:

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted - docs/examples/demo/demo.cpp - docs/examples/demo/demo.hpp
clang-tidy reports: 7 concern(s) - **docs/examples/demo/demo.cpp:3:10:** warning: [[modernize-deprecated-headers](https://clang.llvm.org/extra/clang-tidy/checks/modernize/deprecated-headers.html)] > inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead ```cpp #include ^~~~~~~~~ ``` - **docs/examples/demo/demo.cpp:8:5:** warning: [[modernize-use-trailing-return-type](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-trailing-return-type.html)] > use a trailing return type for this function ```cpp int main(){ ~~~ ^ auto -> int ``` - **docs/examples/demo/demo.cpp:10:13:** warning: [[readability-braces-around-statements](https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html)] > statement should be inside braces ```cpp for (;;) break; ^ { ``` - **docs/examples/demo/demo.cpp:13:5:** warning: [[cppcoreguidelines-pro-type-vararg](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/pro-type-vararg.html)] > do not call c-style vararg functions ```cpp printf("Hello world!\n"); ^ ``` - **docs/examples/demo/demo.hpp:6:11:** warning: [[modernize-use-default-member-init](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html)] > use default member initializer for 'useless' ```hpp char* useless; ^ {"\0"} ``` - **docs/examples/demo/demo.hpp:7:9:** warning: [[modernize-use-default-member-init](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html)] > use default member initializer for 'numb' ```hpp int numb; ^ {0} ``` - **docs/examples/demo/demo.hpp:11:11:** warning: [[modernize-use-trailing-return-type](https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-trailing-return-type.html)] > use a trailing return type for this function ```hpp void *not_useful(char *str){useless = str;} ~~~~~~^ auto -> void * ```

Have any feedback or feature suggestions? Share it here.

2bndy5 commented 3 months ago

@jnooree The logs are out of order. The multi-threaded logs appear after the "posting comments" step (which is the last step). Since our workflow has verbosity set to debug, we can see all the logs from the captured output of clang-tidy and clang-format.

Is there a reason why sys.stdout() would only show output after the loggers are destructed? This might be specific to GitHub Actions runners.

UPDATE: should be fixed in cpp-linter/cpp-linter#98 (released in v1.8.1)

2bndy5 commented 3 months ago

@dependabot rebase

2bndy5 commented 3 months ago

Do not merge!

cpp-linter v1.8.0 will skew the logs. See https://github.com/cpp-linter/cpp-linter/issues/97

I'm waiting to see how dependabot behaves when it finds I've released cpp-linter v1.8.1 to fix the logs.

dependabot[bot] commented 3 months ago

Superseded by #227.

shenxianpeng commented 3 months ago

I manually trigged Dependabot update https://github.com/cpp-linter/cpp-linter-action/network/updates

2bndy5 commented 3 months ago

I didn't know it could be manually triggered. 😕

shenxianpeng commented 3 months ago
image
2bndy5 commented 3 months ago

Oh I found that button now. 🎉