cpp-linter / cpp-linter-rs

A CLI tool that scans a batch of files with clang-tidy and/or clang-format, then provides feedback in the form of comments, annotations, summaries, and reviews.
https://cpp-linter.github.io/cpp-linter-rs/
MIT License
1 stars 0 forks source link

feat: add optional colored log output #52

Closed 2bndy5 closed 1 month ago

2bndy5 commented 1 month ago

Uses a new dependency colored to get cross-platform compatible for terminal colors. Supports an environment variable CPP_LINTER_COLOR that (if set to 1, on, or true) will force color output when it is automatically disabled (see colored features which follows standards).

I also moved the log grouping functions into the rest_api module. Technically, the log grouping commands we currently use are specific to GitHub. Other Git servers (like GitLab) implement these differently.

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve the addition of a new dependency, colored, to the README.md and Cargo.toml files, along with updates to the logging system within the cpp-linter project. The logging mechanism has been enhanced by integrating the RestApiClient, replacing existing logger calls with new methods for managing log groups. Additionally, modifications to the GithubApiClient and TestClient include new methods for logging, and the run_main function has been adjusted to utilize the new logging structure. Overall, these changes improve the logging capabilities and dependency management.

Changes

File Change Summary
README.md Added new dependency colored licensed under MPL-2.0.
cpp-linter/Cargo.toml Added dependency colored = "2.1.0". Updated log dependency to log = { version = "0.4.22", features = ["std"] }.
cpp-linter/src/clang_tools/mod.rs Integrated RestApiClient into logging; updated capture_clang_tools_output function signature.
cpp-linter/src/logger.rs Added SimpleLogger struct; updated logging methods to use colored crate; removed start_log_group and end_log_group from public API.
cpp-linter/src/rest_api/github/mod.rs Added start_log_group and end_log_group methods to RestApiClient implementation in GithubApiClient.
cpp-linter/src/rest_api/mod.rs Added start_log_group and end_log_group methods to RestApiClient; updated TestClient for logging.
cpp-linter/src/run.rs Updated run_main function to use RestApiClient for logging operations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RunMain
    participant RestApiClient
    participant GithubApiClient

    User->>RunMain: Start process
    RunMain->>RestApiClient: start_log_group("Get list of specified source files")
    RestApiClient->>GithubApiClient: start_log_group("Fetching files")
    GithubApiClient-->>RestApiClient: Log files fetched
    RestApiClient->>RunMain: end_log_group()
    RunMain->>RestApiClient: start_log_group("Posting feedback")
    RestApiClient->>GithubApiClient: post_feedback()
    GithubApiClient-->>RestApiClient: Log feedback posted
    RestApiClient->>RunMain: end_log_group()
    RunMain-->>User: Process completed

🐇 "With colors bright and logs so neat,
The changes hop, a joyful feat!
A client new to guide the way,
In every log, a bright display!
From files to feedback, all in sync,
Let's celebrate with a happy wink!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.48%. Comparing base (da09e54) to head (7062177). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ========================================== + Coverage 97.45% 97.48% +0.03% ========================================== Files 14 14 Lines 3295 3338 +43 ========================================== + Hits 3211 3254 +43 Misses 84 84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.